Skip to content

fix(ui): OAuthConsent AuthenticatedRoutes usage - #8327

Merged
wobsoriano merged 2 commits into
mainfrom
carp/fix-oauth-redirect-to-sign-in
Apr 15, 2026
Merged

fix(ui): OAuthConsent AuthenticatedRoutes usage#8327
wobsoriano merged 2 commits into
mainfrom
carp/fix-oauth-redirect-to-sign-in

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Apr 15, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 15, 2026 11:02pm

Request Review

@changeset-bot

changeset-bot Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d64c25c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the ui label Apr 15, 2026
@coderabbitai

coderabbitai Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 04b3cfec-0e33-4d29-95b1-d6ab95bd4819

📥 Commits

Reviewing files that changed from the base of the PR and between f800b4f and d64c25c.

📒 Files selected for processing (3)
  • .changeset/fix-oauth-consent-redirect.md
  • packages/ui/src/components/OAuthConsent/OAuthConsent.tsx
  • packages/ui/src/components/OAuthConsent/__tests__/OAuthConsent.test.tsx
📝 Walkthrough

Walkthrough

This pull request fixes an OAuth consent redirect issue by refactoring the OAuthConsent component to use the AuthenticatedRoutes pattern. A changeset documents the patch release for @clerk/ui. The component structure is updated by removing Flow.Root wrappers from error, loading, and success paths, replacing the original HOC-based export with a new OAuthConsentInternal component that uses router-based composition with Route/Switch. The corresponding test is updated to verify UI element presence rather than root element nullity.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a template with a checklist but does not provide substantive details about the changes, testing instructions, or linked issue. Add a brief summary of what was changed and why (e.g., explaining the OAuth consent redirect issue and the solution), testing instructions, and link to the related issue if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: refactoring OAuthConsent to use AuthenticatedRoutes pattern for proper redirect handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Apr 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8327

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8327

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8327

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8327

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8327

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8327

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8327

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8327

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8327

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8327

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8327

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8327

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8327

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8327

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8327

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8327

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8327

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8327

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8327

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8327

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8327

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8327

commit: d64c25c

@wobsoriano
wobsoriano merged commit 45b773a into main Apr 15, 2026
42 checks passed
@wobsoriano
wobsoriano deleted the carp/fix-oauth-redirect-to-sign-in branch April 15, 2026 23:32
@clerk-cookie clerk-cookie mentioned this pull request Apr 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsoriano wobsoriano wobsoriano approved these changes

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter @wobsoriano